Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when specifying port name as origin for move operation #572

Closed
tvt173 opened this issue Aug 5, 2022 · 3 comments · Fixed by #573
Closed

Error when specifying port name as origin for move operation #572

tvt173 opened this issue Aug 5, 2022 · 3 comments · Fixed by #573

Comments

@tvt173
Copy link
Collaborator

tvt173 commented Aug 5, 2022

Hi,
Previously we were able to supply a port name on the component reference as an origin for a move operation. This is now broken because of the renaming of midpoint to center. The problem is that str also has an attribute called center. I would recommend we check if the origin is a string first to catch this case.

if hasattr(origin, "center"):

@joamatab
Copy link
Contributor

joamatab commented Aug 5, 2022

Hi Troy, can you provide some code to reproduce the error? That way we can add a test for it:)

@joamatab
Copy link
Contributor

joamatab commented Aug 5, 2022

i added a test for it and a fix

@tvt173
Copy link
Collaborator Author

tvt173 commented Aug 6, 2022

thanks @joamatab !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants