Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for different mesh size in x and y in tidy3d #719

Closed
mdecea opened this issue Sep 15, 2022 · 1 comment
Closed

Allow for different mesh size in x and y in tidy3d #719

mdecea opened this issue Sep 15, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@mdecea
Copy link
Collaborator

mdecea commented Sep 15, 2022

Right now, it seems like the tidy3d simulations in modes.py only allow for uniform grid with the same number of cells in x and y., which is pretty inflexible.

Important note: although in the argument description in the docstring it says that resolution is the number of pixels/um, that's not true! Resolution is indeed the total number of cells in the x and y directions.

I want to request for at least the possibility of allowing different number of cells in the x and y directions. I have it implemented in my local copy of gdsfactory, so if you agree I can just create a PR. Just want to ask first because it is likely that some code will have to change as I have it implemented taking as parameters resolution_x and resolution_y instead of resolution (for example get_simulation_xsection.py will for sure have to change.

@mdecea mdecea added the enhancement New feature or request label Sep 15, 2022
@simbilod
Copy link
Collaborator

You could also make resolution_x and resolution_y new Optional parameters that override resolution if set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants