Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gf.geometry.outline(.. open_ports=True...) returning odd error #888

Closed
bobnifty opened this issue Nov 17, 2022 · 2 comments
Closed

gf.geometry.outline(.. open_ports=True...) returning odd error #888

bobnifty opened this issue Nov 17, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@bobnifty
Copy link

Describe the bug
gf.geometry.outline(open_ports=True)
gives an error:
"ValueError: port = 'E' not in 'compass_size10p0006__20p0' ports ['e1', 'e2', 'e3', 'e4']"

To Reproduce
comp1 = gf.components.taper(length=100,width1=20,width2=50)
outline_comp1 = gf.geometry.outline(comp1,open_ports=True)

Expected behavior
Returns outline of original component with the ports 'open' (not outlined)

Suggested fix
Maybe reverting to the phidl wrap?

@bobnifty bobnifty added the bug Something isn't working label Nov 17, 2022
@bobnifty
Copy link
Author

Actually it seems like just pointing the port to 'e3' seems to work....

@joamatab
Copy link
Contributor

Thank you Robert for posting the issue and suggesting the fix

https://github.com/gdsfactory/gdsfactory/pull/893/files

releasing 6.1.1 with the fix and a test for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants