Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for delay lines #911

Closed
simbilod opened this issue Nov 22, 2022 · 1 comment
Closed

Add tests for delay lines #911

simbilod opened this issue Nov 22, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@simbilod
Copy link
Collaborator

Describe the bug
Some delay line components lay out a different length than the one passed as argument (see e.g. #909 for a quick fix to delay_snake3)

Suggested fix
We need tests specificlaly for delays that is independent of just tallying length, for instance compute the component area with c.area() and dividing by waveguide width.

More generally, we need more robust LVS, or some comparison of layout to design intent

@simbilod simbilod added the bug Something isn't working label Nov 22, 2022
@joamatab
Copy link
Contributor

joamatab commented Nov 23, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants