Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gf tool install issues #943

Closed
joamatab opened this issue Dec 1, 2022 · 4 comments
Closed

gf tool install issues #943

joamatab opened this issue Dec 1, 2022 · 4 comments

Comments

@joamatab
Copy link
Contributor

joamatab commented Dec 1, 2022

    Hello @joamatab ,

I installed the latest version and did a fresh install of klayout, and tried to use the cli tool to install the salt package. I ran into a couple of issues:

  1. The cli tool is broken and does not take in any commands and errors out. I had to manually fix it by opening the gf file and changin gf to cli everywhere.

Screenshot 2022-11-30 2.37.26 PM.png

  1. After getting this working, I ran gf tool install and it was installed in the salt directory. Opening klayout did not show the menu item for gdsfactory:

Screenshot 2022-11-30 2.39.37 PM.png

Moving the gdsfactory folder to macros rather than salt brings the menu back:

Screenshot 2022-11-30 2.41.03 PM.png

Is there a reason we have to keep this under salt? Does it change it's functionality in any way by moving it to macros? Atleast keeping it under macros brings it in toolbar. Having it under salt makes it inaccessible.

Perhaps @thomasdorch knows?

Originally posted by @SkandanC in #937 (comment)

@sebastian-goeldi
Copy link
Collaborator

sebastian-goeldi commented Dec 1, 2022

If you want it installable by the package manager it needs to go to the salt folder, that's where all packages managed by the saltmine live. I believe though you have an error in your setup. Python macros need to go the pymacros folder. macros is for ruby. That might be the problem. I think the standard packages might detect this and can run it successfully anyway, but not for packages.

@joamatab
Copy link
Contributor Author

joamatab commented Dec 4, 2022

Skandan,

is it working now?

@sebastian-goeldi
Copy link
Collaborator

sebastian-goeldi commented Dec 4, 2022

I believe this will not work. Klayout has two kinds of python files. .py and .lym They get loaded differently. .py are the "traditional" python files and go into /python. .lym are the xml wrapped python files that also hold klayout information. These are the ones called by the macro class (forgot the exact name) and can be set to autoexecute etc. They need tp be in /pymacros. I believe if they are in /python, they won't be properly executed on startup anymore.

The traditional python files can also only be loaded by the macros files, i.e. only from a macro and not even started by themselves (they can be loaded from the macros development python shell though, or as a input argument for a macros loaded as an argument passed to klayout on startup)

@SkandanC
Copy link
Contributor

SkandanC commented Dec 5, 2022

@joamatab yes it works now.

@joamatab joamatab closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants