Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue on page /notebooks/sax_01_sax.html #108

Closed
joamatab opened this issue Sep 11, 2023 · 3 comments
Closed

Issue on page /notebooks/sax_01_sax.html #108

joamatab opened this issue Sep 11, 2023 · 3 comments

Comments

@joamatab
Copy link
Contributor

joamatab commented Sep 11, 2023 •
edited

image

https://gdsfactory.github.io/gplugins/notebooks/sax_01_sax.html#phase-shifter-model

@flaport
@simbilod
@flaport
Copy link
Collaborator

flaport commented Sep 11, 2023

SAX multimode behavior has changed in its most recent version.

Previously one specified a list of modes supported by the circuit.

Now each port in the circuit possibly supports a different set of modes: more general and more correct.

I can take a look at the issue later this week.

@joamatab
Copy link
Contributor Author

Hi Floris, shall we pin SAX to the former version?

@joamatab
Copy link
Contributor Author

How about the new release?

@joamatab joamatab mentioned this issue Sep 19, 2023
Closed
@joamatab joamatab closed this as completed Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joamatab @flaport