New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import_gds differend keywords #371

Closed

nikit-k-a opened this issue Apr 22, 2024 · 1 comment · Fixed by #376

nikit-k-a commented Apr 22, 2024 •

edited

In ubcpdk/import_gds.py in function add_ports:

As from gdstk docs (https://heitzmann.github.io/gdstk/library/gdstk.Label.html) label has no position, should use origin instead maybe?
same for gf.Port - there is no midpoint as of my knowledge. Use center maybe?

The text was updated successfully, but these errors were encountered:

joamatab mentioned this issue

Remove unused add ports #376

Merged

Contributor

joamatab commented Apr 30, 2024

Hi Nikita,

you are right, thanks for pointing that out!

i also realized that the function was not used and deleted it entirely
#376

joamatab closed this as completed in #376

sourcery-ai-experiments-bot mentioned this issue

Remove unused add ports sourcery-ai-experiments/ubc#1

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment