skip_groups doesn't work for subgroup

[aleung]

Describe the bug

On our GitLab server, there is a top level group ei and several levels of subgroups under it.

My config file has subgroup name set into skip_groups:

projects_and_groups:
  "*":
    # configurations
skip_groups:
  - ei/demo

Run gitlabform on the group ei:

gitlabform ei

I expect the projects ei/demo/* are skipped, but all of them had be configured.

Read the source code, I saw that _remove_skipped_groups is called only when target is ALL or ALL_DEFINED and isn't applied if target is a group.

https://github.com/egnyte/gitlabform/blob/dbb53da60c5366295a4269fec2577b34be1a862f/gitlabform/input.py#L28

GitLabForm version

2.2.0

[gdubicki]

Hi @aleung ! Thanks for reporting this.

I am not sure if we should treat it as a bug or a feature request though. This kind of matters because I try to fix bugs ASAP while the feature requests are preferred to be developed by the community with PRs. 😅

Anyway, if you got this far that you saw the code that would need to be changed to fix implement it, perhaps you could provide a Pull Request?

[gdubicki]

Implemented/fixed in v2.4.0, released a moment ago.

[aleung]

#276 hasn't fixed it.

projects_and_groups:
  "*":
    # configurations
skip_groups:
  - ei/demo

If the CLI parameter points to the subgroup , it's skipped as expected.

gitlabform ei/demo

But when the parameter points to the parent group, the subgroup isn't skipped.

gitlabform ei
# ei/demo isn't skipped

I'll check if I'm able to raise a PR to address it.