Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change theme for some filetypes #1059

Closed
thdoan opened this issue Jun 9, 2016 · 8 comments
Closed

Cannot change theme for some filetypes #1059

thdoan opened this issue Jun 9, 2016 · 8 comments

Comments

@thdoan
Copy link

thdoan commented Jun 9, 2016

Steps to reproduce:

  1. Unzip Geany Portable 1.27 to a folder and run it
  2. Open a CSS or XML file
  3. Select View / Change Color Scheme

I got this prompt:

image

No matter what theme I select, the theme for CSS and XML files is stuck on Default (though for other filetypes the theme is updated properly).

@thdoan
Copy link
Author

thdoan commented Jun 9, 2016

Never mind -- I had to go into GeanyPortable\Data\settings\filedefs and manually remove the styles defined in the files there in order to fix this.

@thdoan thdoan closed this as completed Jun 9, 2016
@elextr
Copy link
Member

elextr commented Jun 9, 2016

Yes, those filetypes specifically define styles, because they have syntactic entities that are special to those filetypes and not (or unlikely to be) covered by most colour schemes.

@thdoan
Copy link
Author

thdoan commented Jun 10, 2016

Instead of adding the overriding styles there, can we add a comment instead, e.g.:

# To override a style, copy the styles from the respective file inside GeanyPortable\App\DefaultData\settings\filedefs

Perhaps this is something for the PortableApps team to consider.

@codebrainz
Copy link
Member

I don't know what this issue is about, but that comment is not accurate. It's extremely rare that any user should modify any style mappings in the filedefs/filetypes.* files, those mappings are only there for legacy reasons. CSS and XML should work with all colour schemes out-of-the-box, barring any bugs in the Portable version.

@thdoan
Copy link
Author

thdoan commented Jun 10, 2016

I think this was an issue with the portable version. When I removed all the files in GeanyPortable\Data\settings\filedefs and restarted Geany, I was able to change themes without any issues.

@codebrainz
Copy link
Member

@thdoan where do you get a zip file for Geany Portable? I was going to see if maybe they had a problem with the configuration files, but all I could find was a Win32 .exe file (definitively not portable :)

@thdoan
Copy link
Author

thdoan commented Jun 10, 2016

@codebrainz Here's how you can reproduce this using Geany Portable:

  1. Downloaded it from http://portableapps.com/apps/development/geany_portable
  2. Install into any folder
  3. Start Geany

You should see bunch of files in GeanyPortable\Data\settings\filedefs with overriding styles that prevent you from changing the theme. Geany Portable should not copy over these files on first start, or at least leave out the overriding styles, which could be confusing for first-time users.

@codebrainz
Copy link
Member

I got from your original PR description that there was a zip file I could unzip on my Linux. If not, I'll try and remember to check it out next time I'm in the Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants