Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find Previous disabled #1494

Closed
oonet opened this issue May 12, 2017 · 9 comments
Closed

Find Previous disabled #1494

oonet opened this issue May 12, 2017 · 9 comments
Labels
can't reproduce A developer couldn't reproduce the issue

Comments

@oonet
Copy link

oonet commented May 12, 2017

Find dialog shows "Next" enabled but "Previous" disabled.

Xubuntu 17.10 with latest version of Geany from repository (1.29)

@elextr
Copy link
Member

elextr commented May 12, 2017

Doesn't happen for me with latest Geany. Perhaps you need to give more information about what you are doing.

@elextr elextr added the can't reproduce A developer couldn't reproduce the issue label May 12, 2017
@oonet
Copy link
Author

oonet commented May 15, 2017

Open new document. Select "Find" from "Search" menu (ctrl+f). Next is enabled, Previous is disabled.

@elextr
Copy link
Member

elextr commented May 15, 2017

Don't have Xubuntu, but doesn't happen here, what versions of GTK and Glib is it using? Can you try the latest version of Geany (1.30.1) from the PPA.

@codebrainz
Copy link
Member

It happens here if you enable regular expression searching, which makes sense since it probably can't match expressions backwards.

@oonet
Copy link
Author

oonet commented May 16, 2017

Good catch! Previous doesn't work with regular expressions enabled, but does work with regular expressions disabled. As you say, makes sense. Fixed!

@oonet oonet closed this as completed May 16, 2017
@dicktyr
Copy link

dicktyr commented Jan 27, 2018

I'm surprised this has remained broken for so long, and further surprised that the issue was closed (at least twice)! Navigating to the previous regex match remains broken in the latest Geany (1.32) and, unfortunately, this appears to be "by design" (the same bug was reported in 2011)!

In any case, Geany is the only text editor I've used which does not support navigating to the previous regex match.

@elextr
Copy link
Member

elextr commented Jan 27, 2018

@dicktyr its not by design, its because the regular expression library does not support searching backwards so it would require finding all matches forwards from the start of the document and picking the one before the current position and nobody has written the code. Pull requests that add the facility are welcome, attempts to shame volunteer contributors are not.

@dicktyr
Copy link

dicktyr commented Feb 2, 2018

nobody has written the code

hence it seems quite reasonable that this issue should remain open until then
and potential writers may appreciate this: https://github.com/google/re2/wiki/WhyRE2

(@elextr by the way, I made no attempt to shame anybody
but rather to bring attention to some simple facts)

@elextr
Copy link
Member

elextr commented Feb 2, 2018

@dicktyr the OP closed the issue, not any of the Geany contributors, thats their decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can't reproduce A developer couldn't reproduce the issue
Projects
None yet
Development

No branches or pull requests

4 participants