Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated scintilla_changes.patch for update-scintilla.sh #1606

Open
AlbertoGP opened this issue Sep 21, 2017 · 1 comment
Open

Outdated scintilla_changes.patch for update-scintilla.sh #1606

AlbertoGP opened this issue Sep 21, 2017 · 1 comment
Assignees

Comments

@AlbertoGP
Copy link

Hi, I've compiled Geany from source (works great!) and now I'm trying to make some customizations to Scintilla, using scripts/update_scintilla.sh

Importing the files from the downloaded copy of Scintilla works fine, but the patch step does not because the file scintilla/scintilla_changes.patch does not match: it says it was for 3.54 and the current version of Scintilla in Geany is 3.7.5.

Are you still using this mechanism for importing Scintilla releases, or something else?

@elextr
Copy link
Member

elextr commented Sep 22, 2017

As @codebrainz assigned, we use @b4n to do the updates 😁, in other words it manual.

This is because checking compatibility between the styling Scintilla produces and the styling Geany maps (what was changed?, what new styles do languages have?, what styles have they removed?) can only be done manually.

@AlbertoGP AlbertoGP changed the title outdated scintilla_changes.patch for update-scintilla.sh Outdated scintilla_changes.patch for update-scintilla.sh Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants