Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filetypes.README: unprecise/incomplete path #1640

Open
lpaulsen93 opened this issue Oct 13, 2017 · 5 comments
Open

filetypes.README: unprecise/incomplete path #1640

lpaulsen93 opened this issue Oct 13, 2017 · 5 comments

Comments

@lpaulsen93
Copy link
Contributor

The path to look for filetypes files mentioned in filetypes.README is /usr/share/geany. This is not correct for Ubuntu. Under Ubuntu the path is /usr/local/share/geany.

It should be considered to mention both pathes (or even more if known for other linux distributions). So I suggest to extend the text in the README file.

I did not check because I am not using Windows at home but is the README file the same for windows? It will also have a different path of course.

@frlan
Copy link
Member

frlan commented Oct 13, 2017

Maybe it should be replace by something like $PREFIX

@lpaulsen93
Copy link
Contributor Author

What you mean? $PREFIX literally? Or would the makefile put in the corresponding path?

@b4n
Copy link
Member

b4n commented Oct 14, 2017

@LarsGit223 actually the location directly depends where Geany was installed, so it we want to have it perfectly right we should generate the file at build time.

@elextr
Copy link
Member

elextr commented Oct 14, 2017

@LarsGit223 by $PREFIX @frlan means the location geany is built to be installed into, which is why @b4n noted it has to be set at build time.

Well at build or install time, sed experts are welcome to make a pull request.

@eht16
Copy link
Member

eht16 commented Oct 14, 2017

I'd vote rather for a more generic phrasing.
/usr/share should be right for most users as this is usually the path used by distro packages. /usr/local/share is the default if you compile from source yourself and do not specify an installation prefix, this is not the way most users do install Geany, I guess.
Those users who install Geany from source and use a custom prefix, probably know what they are doing and so also can mentally replace the provided default path in the documentation/README with that they used for ./configure.

In the documentation, we already have a few paragraphs about different config/resource file paths, see http://geany.org/manual/#configuration-file-paths. Maybe we could just refer to this part of the docs in the README?

Something like "$PREFIX" could rather increase confusion for users rather than solving it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants