Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not set bookmarks using the mouse #1699

Open
rovf opened this issue Nov 30, 2017 · 11 comments
Open

Can not set bookmarks using the mouse #1699

rovf opened this issue Nov 30, 2017 · 11 comments

Comments

@rovf
Copy link

rovf commented Nov 30, 2017

I can set a bookmark using the keyboard shortcut control-m, but I can not set it with the mouse. When I move the mouse to the left margin (i.e. where the line numbers are displayed) and do a context-click (left-click), I get the normal context menu, and this does not provide a "set bookmark" entry.

Using Geany 1.30.1 on Windows 7.

@kugel-
Copy link
Member

kugel- commented Nov 30, 2017

On my system right click opens the context menu. Left click adds a bookmark (adds the small + sign)

@rovf
Copy link
Author

rovf commented Nov 30, 2017

This gave a hint to a problem. First, I confused in my description "left" and "right" click, because I have set my mouse to left handed. More importantly, I found that with what is commonly known as "left click", it indeed DOES add a bookmark, but the problem is that the "left margin" is not, as I thought, the area with the line numbers, but a very tiny (small) area between the line number and the edit pane. Since it also is coloured the same as the line number area, it is virtually impossible to see. I just found it by accident.

@elextr
Copy link
Member

elextr commented Nov 30, 2017

Yes, its the markers margin, for showing the markers, so its sized to fit the markers and nothing else.

@rovf
Copy link
Author

rovf commented Nov 30, 2017

Is there a way to have it coloured differently, so that I can at least see it? If not, this would be a feature request. It would also be convenient to be able to style the line number area (foreground/background colour).

@elextr
Copy link
Member

elextr commented Nov 30, 2017

AFAIK Geany has no way to set the background colour of any margin except the folding margin, but I believe its available from Scintilla, so a pull request adding it to the colour schemes would probably be accepted.

@andy5995
Copy link
Contributor

andy5995 commented Jan 22, 2019

I can set a bookmark using the keyboard shortcut control-m, but I can not set it with the mouse.

This is an issue for me when the debugger plugin is active. Left-clicking will cause a red diamond to be displayed in the area where the green plus sign should show, which contradicts what the docs say.

On Geany 1.29.. Debian Stretch and Buster (installed from the Debian repo). (I'm working on building the debugger plugin from git and testing it on the latest git version of Geany to see if the behavior is the same)

EDIT/UPDATE: same behavior when I built and installed the plugin from git.

@elextr
Copy link
Member

elextr commented Jan 22, 2019

@andy5995 not sure if this is the cause, but there is nothing stopping multiple plugins registering different icons for the same marker, so if you have multiple plugins that use the marker margin running at the same time they might tread on each others icons.

@andy5995
Copy link
Contributor

Hmm.. I kind of get what you're saying.. but there is nothing to tread on. I left-click and the red diamond shows up which indicates a break point is set. It's not registering as a bookmark, as I've tested it by left-clicking in a few areas and then using CTRL+. to cycle through, but nothing happens. If I use CTRL+m to set a bookmark, I can navigate through them using CTRL+..

Basically it seems the debugger plug-in is just taking precedence over the bookmark feature.

@elextr
Copy link
Member

elextr commented Jan 22, 2019

I guess debugger is on the margin click signal list before bookmark, so it gets the click and returns (true/false I forget which it is) that indicates that the signal has been handled and not to call other handlers on the list.

@elextr
Copy link
Member

elextr commented Jan 22, 2019

Basically nothing manages resources shared between plugins, and most are written as if they own the resource, markers, signals, and a bunch of other things. There have been discussions about how to handle it, but no resolution to date.

@elextr
Copy link
Member

elextr commented Jan 22, 2019

And a final thought, sharing clicks on the markers margin is hard because there is nothing to indicate which functionality the user wanted with that click, bookmark, or debugger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants