Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages window height 0 - irritating #1926

Closed
hartmut27 opened this issue Aug 20, 2018 · 9 comments
Closed

Messages window height 0 - irritating #1926

hartmut27 opened this issue Aug 20, 2018 · 9 comments

Comments

@hartmut27
Copy link

Feature Request:

You can close Messages Window.
But on Linux you can set its height to 0 also
(dragging window top frame border with mouse down to lower bar of screen).

Then the Message window is active, but you can't see its contents.
e.g. when starting Find in Files, you get some search results, but you can't see and this is irritating.

@elextr
Copy link
Member

elextr commented Aug 20, 2018

What is the feature request? The above seems to be a series of statements of existing capability.

@hartmut27
Copy link
Author

When the "message window resize / set height to 0" event occurs, ignore this event, instead hide message window. Later, when the user unhides the message window (e.g. showing Find in Files results) the message window reappears in its original dimension.

@codebrainz
Copy link
Member

What if the user set it to 0 height on purpose to prevent it from popping up all the time? (I do this)

@hartmut27
Copy link
Author

Which function does pop op the message window and you don't want this?
To prevent this I propose you write a separate feature request supressing this behavior. e.g. a new option "Popup Message Window automatically y/n".

@elextr
Copy link
Member

elextr commented Aug 21, 2018

@hartmut27 I don't understand why you want set height 0 to hide the window? If you want to hide it do that. Menu->View->Show message window unticked, and/or define a keybinding for it if you want to (I use Alt+m).

@hartmut27
Copy link
Author

@elextr I don't "want" to set the height 0. the message window has no close button (no cross icon in the right upper corner, as notepad++ does for example). perhaps with an close window icon this request would me less imortant...
to use the menu option to close a window - this seems to be a bit over-complicated.
one way or another... a window with height 0 which formally is in visible state, and at the same time is not visible, does not make sense to me and confuses users in my eyes. this is the reason why I've issued this topic. notepad++ on windows has the same behaviour, i must confess.
but most apps I use day to day don't allow this ambivalent setting.

@elextr
Copy link
Member

elextr commented Aug 23, 2018

to use the menu option to close a window - this seems to be a bit over-complicated.

define a keybinding as I said.

As far as window size 0 or 1 or 2 etc Geany takes the approach for most things that if the user set it they meant to do it, and so it does what it is told and isn't too smart for its own good. Geany is an IDE after all, for programmers, who should be given at least a sliver of doubt that they intended it.

You will also notice that the message pane has no top bar, that would need to be added to put your button in, and an option to remove it for those who would prefer not to waste so much real estate for a button they don't use. But a well written pull request may be accepted.

@codebrainz
Copy link
Member

codebrainz commented Aug 23, 2018

It's fairly common to allow totally collapsing a paned/split view. GTK+ allows it by default (and so all GTK+ apps which haven't added special code to prevent it), and Qt even has friendlier behaviour where once you get close to fully collapsing it, it snaps shut, making it a little more obvious what the behaviour is. I don't think WinForms or Cocoa prevent users from fully collapsing split views either.

The only slightly odd/confusing part is that Geany doesn't re-expand it when it wants to show something in the collapsed side of the splitter, which for me is a plus, but probably not for everyone. I don't expect it would be highly controversial if someone wanted to make a patch to expand the message window when it needs attention (would be fairly easy to code), but then the question becomes how big to make it, since the previous size was zero, it would have to be some hardcoded size. It could use GEANY_MSGWIN_HEIGHT I suppose.

@hartmut27
Copy link
Author

Thanks for your ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants