Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo does not work from replace dialog #2108

Open
dsjstc opened this issue Mar 21, 2019 · 6 comments
Open

Undo does not work from replace dialog #2108

dsjstc opened this issue Mar 21, 2019 · 6 comments

Comments

@dsjstc
Copy link

dsjstc commented Mar 21, 2019

When I type out a complex replace regex, there is often an error. I often need to be able to apply and undo several times before I'm satisfied.

At present (Geany 1.33), one must escape from the replace dialog, undo (which only applies to the current document, per #1631), and re-enter the replace dialog. This is poor workflow for a common sequence.

@elextr
Copy link
Member

elextr commented Mar 21, 2019

Although some already complain its too busy, perhaps it would be ok to add an undo button to the dialog.

@dsjstc
Copy link
Author

dsjstc commented Mar 21, 2019

I think it would be sufficient for it to pass the ctrl-Y / ctrl-Z key events to the parent window.

@elextr
Copy link
Member

elextr commented Mar 21, 2019

@dsjstc because the replace dialog is non-modal the edit window isn't its parent IIUC.

@codebrainz
Copy link
Member

codebrainz commented Mar 22, 2019

I think you could use gtk_widget_add_accelerator on the text boxes in the search dialog or perhaps the dialog box itself to handle all the child widgets. It may require some care to avoid interfering with the keybindings of the text entries.

@vstepaniuk
Copy link

vstepaniuk commented May 21, 2019

This is indeed a missing feature..

@elextr
Copy link
Member

elextr commented May 22, 2019

This is indeed a missing feature..

Pull requests are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants