Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Adjust line" preferences setting only works on opened files after closing and reopening them #2589

Closed
ruben39x2 opened this issue Sep 20, 2020 · 1 comment
Labels

Comments

@ruben39x2
Copy link

Tested in Windows and Linux versions, Geany 1.32.

  1. Have two or more files opened with Geany (not sure if with 1 also happens)
  2. Go to Edit > Preferences > Editor
  3. Check the first item in "Features" section; line adjustment.
  4. This should make the lines not to be rendered beyond the right margin of the window, making them split into multiline (not actually adding a \n char, you know). It doesn't happen.
  5. Close the Geany window. Reopen it.
  6. The lines still are not displayed multiline (adjusted).
  7. Close one file tab. Reopen the same file.
  8. Lines are finally correctly rendered.

I think it'd be awesome to see the new preferences setting in effect in (4), although at least in (6) the lines should be correctly rendered.

Please, contact me if further details are needed. Thanks.

@elextr elextr added the invalid label Sep 20, 2020
@elextr
Copy link
Member

elextr commented Sep 20, 2020

Note that 1.32 is a fairly old version and can't remember how it worked, I have tried to translate to current 1.36.

Have two or more files opened with Geany (not sure if with 1 also happens)
Go to Edit > Preferences > Editor
Check the first item in "Features" section; line adjustment.

In the 1.36 its called "Line Wrapping"

This should make the lines not to be rendered beyond the right margin of the window, making them split into multiline (not actually adding a \n char, you know). It doesn't happen.

Line wrapping does not add \n to the contents, it simply renders the content limited to the right margin. You can see that because the line numbers do not display on wrapped content and only increment on line endings actually present in the document.

Each document thats open can have a different wrapping setting by the user via Document->Line Wrapping. The preferences setting is the default used for newly opened documents.

Close the Geany window. Reopen it.
The lines still are not displayed multiline (adjusted).

When Geany is closed and re-opened, document settings for documents open at close are remembered so they can be reopened in much the same state as they were when Geany is closed, so wrapping won't change for files that are reopened.

Close one file tab. Reopen the same file.

But by closing the documents and re-opening you are using the default as its then a newly opened document, thats why the setting changes when you do this.

Lines are finally correctly rendered.

I think it'd be awesome to see the new preferences setting in effect in (4), although at least in (6) the lines should be correctly rendered.

The reason neither of these happens is explained above and is the intended operation to allow per-document wrapping settings.

@elextr elextr closed this as completed Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants