New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual terminal size set to unreasonable value #2705
Comments
Please post the top few lines of |
|
You have entirely missed the lines required TOP down to where you started 😋 |
I swear those lines didn't exist when I copied the first time! |
Sounds like a problem with LibVTE and/or Fish (see this commit), but not Geany. Not sure it's even worth trying to workaround in Geany since the message was removed in Fish and doesn't seem to affect any other shells. |
Sure sure, eaten by Santas reindeers 😁 Anyway, WFM, Fish 3.1.0 which should still have the message IIUC. 11:57:15: Geany INFO : Geany 1.37 (git >= 915cf6e), en_AU.UTF-8 Perhaps the Arch bleeding edge GTK has been changed so it does not calculate a sensible size when the window is hidden. |
@codebrainz Indeed, it might be a problem with LibVTE, but is there a possibility that we are adding/mapping the widget too soon, or are doing something else which is causing this? Thanks for pointing out that the warning has been removed from fish, but this doesn't really remedy the issue. Other shells might just be ignoring this, just like fish has opted to do so from the next version. I am concerned that certain terminal based UI applications may not properly work inside Geany. @elextr It might be a change in how GTK maps the widgets.
I wouldn't consider the latest stable release the "bleeding edge" 😁
This is also possible, but I was under the impression that the terminal isn't started until the "Terminal" tab is opened for the first time. |
IIRC Fish was using minimum 20 columns and 2 lines in its check, which seems arbitrary, unless it's from POSIX standard? Moreover, at least here, Geany's terminal has the correct output for LibVTE has always been weird with respect to sizing due to it always having to update/maintain the terminal size (columns/lines) dynamically on-the-fly and also having to respect GTK+'s widget sizing stuff (pixels width/height), and in addition being inside a GTK+ scrolled window. It's possible a workaround could be implemented, like only spawning the shell command after the VTE widget is sized/realized using a callback and hoping the user doesn't have their message window shrunk down "too" small or by enforcing a minimum width/height somehow like standalone VTE applications do (ex. gnome-terminal, xfce4-terminal), but it doesn't seem worth it to me unless someone volunteers to investigate and make a patch. Note: I can reproduce this issue without Geany or VTE by using XTerm, shrinking it to a small size, and running Fish. |
No its added to the idle list during startup, so it would be created after the widgets and such are created, not on window open (unless its default opened maybe). |
Agree 👍 with @codebrainz "not worth it" |
I think I have discovered a bug in the terminal size calculation done by the VTE in the messages window, I use the fish shell and I always get this message whenever I open the terminal:
Perhaps Geany is initializing the VTE widget too soon, causing it to believe the available size is 0 or some other unreasonable value.
I am using Geany 1.37 and this issue is always reproducible.
The text was updated successfully, but these errors were encountered: