Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlimited Zoom #2750

Open
rexim opened this issue Feb 17, 2021 · 6 comments
Open

Unlimited Zoom #2750

rexim opened this issue Feb 17, 2021 · 6 comments

Comments

@rexim
Copy link

rexim commented Feb 17, 2021

Hello!

I'm a Twitch streamer and quite often on my streams I need to zoom in the text to a really large size for a better dramatic effect. But unfortunately Scintilla imposes a very strict limitation on zoom factor (from -10 to 20): https://www.scintilla.org/ScintillaDoc.html#SCI_ZOOMIN

And I don't really know why! If I remove the SCI_ZOOMIN limitation condition completely in Scintilla itself it works just fine and does not degrade the performance or/and the stability of Geany.

2021-02-17-183107_1382x1043_scrot

Would it be a good idea to remove the SCI_ZOOMIN limit completely (or at least dramatically increase it) and put that change into the scintilla_changes.patch? If yes, I could make a PR for that myself.

@elextr
Copy link
Member

elextr commented Feb 17, 2021

Since Scintilla provides an unlimited SCI_SETZOOM() function, probably adding a toolbar item to set the zoom would be better, then you can go to the size you want in one step, and be sure to always come back to the same size next video.

@rexim
Copy link
Author

rexim commented Feb 18, 2021

@elextr thank you very much for the response! It is indeed a way better idea! I was planning to work on this myself but then realized that using Geany for my use case is a bit of an overkill so I'm switching to SciTE and won't work on this issue in the near future.

Is it needed for anybody else? Should I close it?

@elextr
Copy link
Member

elextr commented Feb 18, 2021

Well, maybe somebody from the emoji brigade might do it.

@xiota
Copy link
Contributor

xiota commented Oct 25, 2021

@elextr The Scintilla documentation says, "These messages let you set and get the zoom factor directly. There is no limit set on the factors you can set, so limiting yourself to -10 to +20 to match the incremental zoom functions is a good idea."

Since Geany upgraded Scintilla versions, the old limit probably no longer applies.

@elextr
Copy link
Member

elextr commented Oct 25, 2021

The limit is set in Scintilla and hasn't changed according to its documentation.

@xiota
Copy link
Contributor

xiota commented Oct 26, 2021

@elextr Sorry, I misunderstood the relevance of that section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants