Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Search for: <keyword-value> when user hits Ctrl+h with exisiting Replace dialog already open #2808

Closed
Keyikedalube opened this issue May 12, 2021 · 3 comments

Comments

@Keyikedalube
Copy link

Suppose we have a lengthy C code and want to refactor existing variable names:

...
    int x_value, y_value;
...
  1. Double click x_value and press Ctrl+h
  2. Resize dialog opens with x_value set as Search for: keyword value
  3. Leave the dialog open
  4. Now double click y_value to highlight it and press Ctrl+h
  5. Resize dialog is brought back to focus but the Search for: keyword isn't updated

I'd like step 5 to update the keyword value with new highlighted value from the editor.

The reason I leave the dialog open is because I want to keep track of the recent keyword that I just replaced without having to undo and redo again when I forget the last changes made to the document.

@elextr
Copy link
Member

elextr commented May 12, 2021

The search dialog was updated to do this in #2697 (after much discussion on that and other issues/PRs) so having replace work the same should be fine if somebody wants to do it.

@erickpaquin
Copy link

@Keyikedalube , @elextr Can this change be closed?

@elextr
Copy link
Member

elextr commented Jan 9, 2023

Yeah, I didn't notice that #2697 did the replace dialog as well.

@elextr elextr closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants