New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should work well in dark mode on its on, by default. #3407
Comments
Geany is a GTK application, so everything except the edit pane should "just work" and follow the desktop GTK theme selected. Certainly here Geany follows the theme selected for the desktop as I change from Mint-Y to Mint-Y dark. And I don't even have to restart Geany. But note the desktop is actually selecting a different theme that somebody has created a CSS for, nothing happened automagically. If this is not happening for you maybe discuss it with your distro. Unfortunately no desktop themes have styles for "compiler error", "compiler context", "compiler message", how remiss of them!!! So additional CSS needs to be supplied for those items, hence The CSS also has no effect on the edit pane because that applies styles to lexical entities, and again no desktop themes have settings for those. So that will always have to have additional setup, hence the "colour scheme" for that. [Edit: same for other editor/IDEs, see Vscode for example.] Making dark/light colour schemes whilst ensuring appropriate visual contrast when there are many colours involved can be done in two ways:
|
#3013 should help wrt compiler window. Regarding having a dark theme by default, why not, but it'll be hard to agree on which one :) (Not that I care myself, dark themes are a terrible idea that doesn't scale anyway. Troll intended 😁 )
That's not entirely true. Nowadays it's usually somewhat possible to know whether the system theme in uses is light or dark, and we could have the same info for editor themes and/or have a "dark default". So sure, people will still want to select their preferred theme, but we could have a default following a tad better the system theme in this case. |
Themes are a terrible idea that leaves your application at the mercy of unknown idiots that "design" them (troll also intended 😁 ) But yes the point being which to agree on?
Thats entirely true. GTK themes do not set properties for lexical entities. The term
What I think you mean is that there is some sort of fuzzy indication by reading the GTK setting Geany could load Or even just shipping [Edit: probably not, just need to ship a Now all it needs is "somebody" to do it. |
It's 2023. It should work better in dark mode out-of-the-box, without requiring the user to manually search the Internet, download/edit/copy config files.
At least one colour theme for dark mode should be included by default, without requiring the user to visit https://www.geany.org/download/themes/
A colour scheme for dark mode for the output panels should be included by default, and either let the user select it in the Preferences or automatically use it in dark mode, not telling users to write a CSS file for it.
The text was updated successfully, but these errors were encountered: