[C, C++] Calltips have missing space after comma for parameters

[ntrel]

This makes it harder to read the signatures. Not sure when it was introduced.
Weirdly C# and D don't have this problem, even though they use the same ctags/parsers/geany_c.c tag parser file as C and C++.

[elextr]

even though they use the same ctags/parsers/geany_c.c tag parser file as C and C++.

No actually, C and C++ use the parser in the cxx subdirectory, the legacy parsers in geany_c.c have Old on their names so they are not picked up.

[ntrel]

Oh OK, thanks (#3032). So looks like C#, D and Java could be changed to the c-based.c parsers from ctags.

[ntrel]

BTW I was looking with meld if there were any upstream ctags changes that might fix this. I found 2 but they don't affect this:

• A typo in cxxTokenCopy that wasn't setting bFollowedBySpace
• Some changes in cxxTokenChainSplitOnComma setting bFollowedBySpace

[elextr]

So looks like C#, D and Java could be changed to the c-based.c parsers from ctags.

c-based.c looks at first glance to be very similar to geany_c.c without C, C++, Vera, or Vala, just C# D and Java, though there may be detail differences.

I guess both originated from the same ctags c.c and diverged during the ctags unmaintained period, then uctags removed C and C++ when the new parser came online. Somebody needs to check that c-based.c contains at least the capability that geany_c.c has, since it gathered changes during the divergence, then they can be synchronised (Vala being the most obvious addition to geany_c.c, and uctags Vera is now its own vera.c) .

IIRC @techee found what he thought were improvements in geany_c.c that are not in upstream (and vice versa). Just needs "somebody" to do it.

[ntrel]

A typo in cxxTokenCopy that wasn't setting bFollowedBySpace

#3478

[ntrel]

Somebody needs to check that c-based.c contains at least the capability that geany_c.c has, since it gathered changes during the divergence, since it gathered changes during the divergence, then they can be synchronised

Yeah, though sending the changes upstream could be a big job due to divergence. I'm looking at the D changes and I expect we should switch to ctags even if it means losing features, because their parser is likely better and my Geany D changes were often hacks. Any important ones I will try to port to ctags.

[techee]

Calltips have missing space after comma for parameters

Yeah, I've noticed that too after switching to the new parser. Does #3478 fix that problem? If so, it should be submitted to universal-ctags first and if it gets merged, we could then port it to Geany.

Oh OK, thanks (#3032). So looks like C#, D and Java could be changed to the c-based.c parsers from ctags.

See universal-ctags/ctags#3327 - my plan was to remove the C/C++ parser in Geany's c.c but I didn't get to it yet. Since most of the ugly code is related to C/C++, the result should then be easier to compare and unify. Note that we also have to switch to cpreprocessor.c/h from lcpp.c/h that Geany's c.c uses. This will be quite complicated for collecting function parameters because uctags does it differently, not at the preprocessor level like Geany and the output isn't as good as with Geany's c.c.

[ntrel]

Does #3478 fix that problem? If so, it should be submitted to universal-ctags first and if it gets merged

No. And it's from universal-ctags :-)

Thanks for the info.