Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bar all green after reload #3824

Open
ntrel opened this issue Apr 8, 2024 · 3 comments
Open

Change bar all green after reload #3824

ntrel opened this issue Apr 8, 2024 · 3 comments
Labels

Comments

@ntrel
Copy link
Member

ntrel commented Apr 8, 2024

See title

geany 2.1 (git >= 06b8e6b) (built on 2024-04-05 with GTK 3.24.33, GLib 2.72.4)

@ntrel ntrel added the bug label Apr 8, 2024
@elextr
Copy link
Member

elextr commented Apr 8, 2024

What should happen on undo of the reload?

@rdipardo
Copy link
Contributor

rdipardo commented Apr 8, 2024

Change bar all green after reload

Known Scintilla defect:

An issue that has appeared with change markers is that SciTE's Revert command leads to the whole document getting a green change mark as revert just reloads each byte of the file. Since its useful to undo to before the revert, this point can't just be set as the start of change history to appear clear.

It may be possible to add a 'revert' state to the change history that could appear clear but its not obvious what the semantics of this state would be.

https://groups.google.com/g/scintilla-interest/c/9zNAgBG4Pd0/m/C46OGiz_CwAJ

At least one downstream project has resorted to emptying the undo buffer on file reload, then toggling change history off and on, to simulate a freshly opened file: notepad-plus-plus/notepad-plus-plus#13858

What should happen on undo of the reload?

I guess that would depend on the state of the files.keep_edit_history_on_reload option . . . ?

@elextr
Copy link
Member

elextr commented Apr 9, 2024

If I read the linked notepad issue correctly notepad can't undo the reload, so truncating there makes sense, but Geany can undo the reload (depending on the option but its default is true IIRC) like Scite. So as Neil says on the Scintilla issue, (thanks for finding, I thought I had seen it somewhere) its not clear how to handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants