Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to disable: Are you sure to replace in the whole session? #3702

Closed
luigifab opened this issue Nov 23, 2023 · 5 comments · Fixed by #3851
Closed

Allow to disable: Are you sure to replace in the whole session? #3702

luigifab opened this issue Nov 23, 2023 · 5 comments · Fixed by #3851

Comments

@luigifab
Copy link

With Geany 2.0 there is a new question for Search and Replace dialog:

Are you sure to replace in the whole session?

image

I'm against, this is unacceptable for me.
Is there, or can you add an option to disable it?
@elextr
Copy link
Member

elextr commented Nov 24, 2023 •
edited

The "In Session" function is not new, all that is new is the warning message, added here.

The "In Session" replace has been available for at least 15 years (as far as I looked).

There is no option to disable it, just don't use it, or say "no" to the warning dialog.

@elextr elextr closed this as completed Nov 24, 2023
@b4n
Copy link
Member

b4n commented Nov 24, 2023

@elextr are you sure you didn't understand the request upside down? I understand as the OP asking to disable the warning and get back the older behavior of not asking confirmation.

@elextr
Copy link
Member

elextr commented Nov 24, 2023 •
edited

@elextr are you sure you didn't understand the request upside down? I understand as the OP asking to disable the warning and get back the older behavior of not asking confirmation.

Good question, could be either, but hey, "somebody" can follow the usual Geany approach of adding another option :-)

Or a "Don't show this again" checkbox on the dialog?

@luigifab
Copy link
Author

Yes I would like to disable the warning.

eht16 added a commit to eht16/geany that referenced this issue Apr 21, 2024
@eht16
Add a various pref to skip 'replace in session' confirmation dialog
8bc9132 
Closes geany#3702.
@eht16 eht16 mentioned this issue Apr 21, 2024
Merged
@eht16 eht16 reopened this Apr 21, 2024
@eht16
Copy link
Member

eht16 commented Apr 21, 2024

A new various pref to disable the confirmation dialog is added in #3851.

thekevinday added a commit to thekevinday/geany that referenced this issue May 3, 2024
@thekevinday
Add feature for disabling the replace whole session confirmation dialog.
452dd10 
This adds a new parameter "interface.confirm_replace_whole_session".

There seems to already be similar changes upstream:
- geany#3851
- geany#3702
eht16 added a commit that referenced this issue May 20, 2024
@eht16
Merge pull request #3851 from eht16/issue3702_add_various_pref_replac…
266bf72 
…e_in_session

Closes #3702.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add various pref replace in session eht16/geany
4 participants
@eht16 @b4n @elextr @luigifab