Geany 1.26 is shipped with a version of grep that doesn't seem to work

[Terry-euclid]

Hi folks,

The find in file dialog generates the following error:

c:\program files\geany\bin\grep: unrecognized option `--include=*.c'

The fix seems to be to replace the grep.exe file with the GNU version of grep.

This was OK in 1.24 as the user had to supply his own grep command and need to make sure it was OK.

Terry

Fresh install of Geany 1.26 on Microsoft Windows [Version 6.1.7601]

[Terry-euclid]

Messages Window ...

grep -nHIirF --include=.c --include=.h --include=_.asm -- int (in directory: D:\projects\OCR\Software\Euclid_OCR\DLL\v1.11)
c:\program files\geany\bin\grep: unrecognized option --include=_.c' Usage: grep [OPTION]... PATTERN [FILE]... Try grep --help' for more information.
Search failed.

Debug Messages ...

09:39:45: Geany INFO : Geany 1.26, English_United Kingdom.1252
09:39:45: Geany INFO : GTK 2.24.10, GLib 2.28.8
09:39:45: Geany INFO : System data dir: C:\Program Files\Geany\data
09:39:45: Geany INFO : User config dir: C:\Users\terry.EUCLID\AppData\Roaming\geany
09:39:46: Geany INFO : System plugin path: C:\Program Files\Geany\lib\geany
09:39:46: Geany INFO : Added filetype BAT (61).
09:39:46: Geany INFO : Added filetype Clojure (62).
09:39:46: Geany INFO : Added filetype CUDA (63).
09:39:46: Geany INFO : Added filetype Cython (64).
09:39:46: Geany INFO : Added filetype Genie (65).
09:39:46: Geany INFO : Added filetype Graphviz (66).
09:39:46: Geany INFO : Added filetype JSON (67).
09:39:46: Geany INFO : Added filetype Scala (68).
09:39:46: Geany INFO : Loaded: C:\Program Files\Geany\lib\geany\filebrowser.dll (File Browser)
09:39:46: Geany INFO : D:\projects\OCR\Software\Euclid_OCR\DLL\v1.11\OCRDisp.cpp : C++ (UTF-8)
09:39:46: Geany INFO : Loaded C:\Program Files\Geany\data\c99.tags (C), 1619 tag(s).

[Terry-euclid]

Hi Folks,

Can anyone else reproduce this or am I the only person seeing this problem?

To try and reproduce do the following:

1. Open a File using Geany V1.26 and Windows
2. Select menu option Search / Find in File ...
3. Enter some text to search for
4. In the Files: dropdown select custom and enter *.c
5. Click the Find button

Terry

[codebrainz]

I can reproduce. Grep 2.4.2 that shipped with Geany 1.26 doesn't have the --include option, must've been added in a later version. I built Grep 2.22 from source and copied it (and dependent libraries) into Geany's bin dir and it works, since that version has this option.

[Terry-euclid]

Hi,

Thanks for coming back to me.

So can I say as you have reproduced this it is a genuine bug and it will get fixed on the next release?

I'm new to this forum so could you confirm if I need to do anything else to get it flagged to be fixed?

Terry

[elextr]

Flagged and milestoned, but thats no guarantee, "somebody" has to actually fix the building of bundle.

[eht16]

Yeah, we'll have to include a newer version of grep.exe into the bundle. As the bundle creation will be reworked anyway for the next release, we'll handle it.
See #560

[eht16]

Just for the records: no matter whether and what version of grep we ship with Geany, you can always change the grep command in the preferences and so easily choose your own version when desired.

[eht16]

@Terry-euclid we've just built test installers for the upcoming 1.27 release. Those contain grep 2.5 from UnxUtils (also a very old grep version but newer than the one included in Geany 1.26). This version has the --include option.

If you feel like testing, here are the links:
http://download.geany.org/snapshots/geany-1.27nightly_setup.exe
http://download.geany.org/snapshots/geany-plugins-1.27nightly_setup.exe

[Terry-euclid]

@eht16 Thanks for tthe updated, I've tested 1.27 nightly and can confirm it now works correctly out of the box, i.e. no need to change grep.

Terry