Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Geany-Themes gallery page to main website #5

Closed
suntong opened this issue Jun 16, 2019 · 7 comments · Fixed by #8
Closed

Add Geany-Themes gallery page to main website #5

suntong opened this issue Jun 16, 2019 · 7 comments · Fixed by #8
Assignees

Comments

@suntong
Copy link

suntong commented Jun 16, 2019

Thanks for providing screenshots, but please add previews to them, so that people can see what they are without even install the whole theme package, because after all, it'll be only a single theme that most people will stick to, or at most one or two.

I can add such preview, if you welcome such PR.

@codebrainz
Copy link
Member

I don't understand the difference between the screenshots and a preview. That was the idea of the screenshots, you could browse through them and get an idea of what each theme looks like.

@suntong
Copy link
Author

suntong commented Jun 16, 2019

Oh, thanks for the fast response. I know I can browse through them, but that's something I want to avoid.

I was thinking building a single page that people can preview all screenshots, without clicking through them one by one.

@codebrainz
Copy link
Member

codebrainz commented Jun 17, 2019

I agree, I think this was discussed a bit somewhere, at least I remember thinking about it. IMO this belongs on the main website, so I'll transfer it to that repository.

With the screenshots PNGs and the JSON index in the geany-themes repo, it should be easy enough to make a page on the main site which creates a themes gallery on-the-fly using JS or some server-side language.

@codebrainz codebrainz transferred this issue from geany/geany-themes Jun 17, 2019
@codebrainz codebrainz changed the title Add preview to the screenshots Add Geany-Themes gallery page to main website Jun 17, 2019
@eht16 eht16 self-assigned this Jun 20, 2019
@eht16
Copy link
Member

eht16 commented Jun 20, 2019

Nice, this sounds like fun :).
I would implement server-side to avoid depending on JS unnecessarily.

@suntong
Copy link
Author

suntong commented Jun 22, 2019

I was indeed preparing to add preview to the screenshots folder for people to easily preview, I'll do it any way, because comparing to server-side implementation, my approach is super simple. I'll do it and post back...

Not objecting server-side implementation, just want to KISS, since such preview file list seldom needs update.

@suntong
Copy link
Author

suntong commented Jun 22, 2019

Done, please check out geany/geany-themes#30 and
https://github.com/suntong/geany-themes/tree/master/screenshots#darculapng

Please note that individual screenshot can be directly linked in url, e.g. I like
https://github.com/suntong/geany-themes/tree/master/screenshots#sleepy-pastelpng

and the title links to the individual screenshot as well, if someone prefer just to see one screenshot.

I'll explain how I did it next, it is semi-automatic, and again, super easy.

@suntong
Copy link
Author

suntong commented Jun 22, 2019

I'll explain how I did it next, it is semi-automatic, and again, super easy.

https://dev.to/suntong/generating-image-preview-easily-opj

and very easy to customize the result too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants