Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-backend): Implement Sandbox on gear side #2544

Merged
merged 58 commits into from
Jul 10, 2023
Merged

feat(core-backend): Implement Sandbox on gear side #2544

merged 58 commits into from
Jul 10, 2023

Conversation

gshep
Copy link
Member

@gshep gshep commented Apr 14, 2023

@reviewer-or-team

@gshep gshep added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed D2-node Gear Node C1-feature Feature request labels Apr 14, 2023
@gshep gshep self-assigned this Apr 14, 2023
@gshep gshep mentioned this pull request Apr 19, 2023
Closed
@grishasobol grishasobol changed the title Draft: Implement Sandbox on gear side Implement Sandbox on gear side Jun 30, 2023
@grishasobol grishasobol added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Jun 30, 2023
@grishasobol grishasobol marked this pull request as ready for review June 30, 2023 12:31
@gshep
Merge remote-tracking branch 'origin/master'
43b6349 
Conflicts:
	core-backend/sandbox/src/runtime.rs
grishasobol
grishasobol reviewed Jul 1, 2023
View reviewed changes
Copy link
Member

@grishasobol grishasobol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First comments

.github/workflows/Update-testnet.yml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
lazy-pages/Cargo.toml Show resolved Hide resolved
node/cli/src/main.rs Show resolved Hide resolved
node/service/src/client.rs Outdated Show resolved Hide resolved
runtime-interface/src/sandbox_mod/detail/get_buff.rs Outdated Show resolved Hide resolved
runtime-interface/src/sandbox_mod/detail/mod.rs Outdated Show resolved Hide resolved
runtime-interface/src/sandbox_mod/detail/mod.rs Outdated Show resolved Hide resolved
ark0f
ark0f approved these changes Jul 5, 2023
View reviewed changes
runtime-interface/src/gear_sandbox/mod.rs Show resolved Hide resolved
sandbox/sandbox/Cargo.toml Show resolved Hide resolved
node/cli/src/main.rs Show resolved Hide resolved
ukint-vs
ukint-vs approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@ukint-vs ukint-vs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great❤️

sandbox-runtime-interface/Cargo.toml Outdated Show resolved Hide resolved
@gshep gshep added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Jul 10, 2023
@ark0f ark0f changed the title Implement Sandbox on gear side feat(core-backend): Implement Sandbox on gear side Jul 10, 2023
@gshep gshep merged commit a79b6e4 into master Jul 10, 2023
@gshep gshep deleted the gshep/sandbox branch July 10, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grishasobol grishasobol grishasobol approved these changes

@ark0f ark0f ark0f approved these changes

@breathx breathx breathx approved these changes

@ukint-vs ukint-vs ukint-vs approved these changes

@NikVolf NikVolf Awaiting requested review from NikVolf

Assignees

@gshep gshep

Labels
A2-mergeoncegreen PR is ready to merge after CI passes B1-releasenotes The feature deserves to be added to the Release Notes C1-feature Feature request D2-node Gear Node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gshep @breathx @grishasobol @ark0f @ukint-vs @shamilsan @sergeyfilyanin