Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(gmeta): add documentation for gmeta crate #2761

Merged
merged 17 commits into from
Jul 12, 2023
Merged

docs(gmeta): add documentation for gmeta crate #2761

merged 17 commits into from
Jul 12, 2023

Conversation

shamilsan
Copy link
Contributor

@shamilsan shamilsan commented Jun 13, 2023 •
edited

Part of #196.

  • Added documentation for gmeta crate.

Will be here: https://docs.gear.rs/gmeta/

@shamilsan shamilsan added the A0-pleasereview PR is ready to be reviewed by the team label Jun 13, 2023
breathx
breathx requested changes Jun 13, 2023
View reviewed changes
gmeta/src/lib.rs Outdated Show resolved Hide resolved
gmeta/src/lib.rs Outdated Show resolved Hide resolved
gmeta/src/lib.rs Outdated Show resolved Hide resolved
gmeta/src/lib.rs Outdated Show resolved Hide resolved
gmeta/src/lib.rs Show resolved Hide resolved
gmeta/src/lib.rs Outdated Show resolved Hide resolved
gmeta/src/lib.rs Outdated Show resolved Hide resolved
gmeta/src/lib.rs Outdated Show resolved Hide resolved
gmeta/src/lib.rs Outdated Show resolved Hide resolved
gmeta/src/lib.rs Outdated Show resolved Hide resolved
@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels Jun 13, 2023
@shamilsan shamilsan added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed and removed A3-gotissues PR occurred to have issues after the review labels Jun 14, 2023
@shamilsan shamilsan added A3-gotissues PR occurred to have issues after the review and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Jun 14, 2023
@shamilsan
Copy link
Contributor Author

Waiting for meta types modifications according to new changes related to replies etc.

@shamilsan shamilsan added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed and removed A3-gotissues PR occurred to have issues after the review labels Jun 19, 2023
@shamilsan
Copy link
Contributor Author

shamilsan commented Jun 19, 2023 •
edited

Will be a little bit updated after #2829

@shamilsan shamilsan added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Jun 19, 2023
@shamilsan shamilsan requested a review from breathx June 19, 2023 16:21
gshep
gshep approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@gshep gshep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! 💯

gmeta/src/lib.rs Outdated Show resolved Hide resolved
@shamilsan shamilsan requested a review from techraed June 20, 2023 13:01
breathx
breathx requested changes Jul 2, 2023
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge master, otherwise lgtm

gmeta/src/lib.rs Outdated Show resolved Hide resolved
@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels Jul 2, 2023
@shamilsan shamilsan added A0-pleasereview PR is ready to be reviewed by the team and removed A3-gotissues PR occurred to have issues after the review labels Jul 4, 2023
@shamilsan shamilsan requested a review from breathx July 4, 2023 09:19
@shamilsan shamilsan merged commit df995d2 into master Jul 12, 2023
10 checks passed
@shamilsan shamilsan deleted the sy-add-gmeta-docs branch July 12, 2023 15:27
@shamilsan shamilsan added the B1-releasenotes The feature deserves to be added to the Release Notes label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshep gshep gshep approved these changes

@breathx breathx breathx approved these changes

@AndrePanin AndrePanin Awaiting requested review from AndrePanin

@techraed techraed Awaiting requested review from techraed

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shamilsan @gshep @breathx