Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lazy-pages): join memory pages implementations #2774

Merged
merged 25 commits into from
Jun 30, 2023
Merged

refactor(lazy-pages): join memory pages implementations #2774

merged 25 commits into from
Jun 30, 2023

Conversation

tltsutltsu
Copy link
Contributor

Resolves #2440.

@tltsutltsu tltsutltsu self-assigned this Jun 14, 2023
@tltsutltsu tltsutltsu added the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label Jun 14, 2023
@NikVolf NikVolf changed the title refactor(lazy-pages): join memory pages realisations refactor(lazy-pages): join memory pages implementations Jun 15, 2023
@tltsutltsu tltsutltsu added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Jun 19, 2023
@tltsutltsu tltsutltsu added A0-pleasereview PR is ready to be reviewed by the team and removed A0-pleasereview PR is ready to be reviewed by the team labels Jun 21, 2023
grishasobol
grishasobol reviewed Jun 22, 2023
View reviewed changes
Copy link
Member

@grishasobol grishasobol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

core/src/pages.rs Outdated Show resolved Hide resolved
lazy-pages/src/mprotect.rs Show resolved Hide resolved
core/src/pages.rs Show resolved Hide resolved
core/src/pages.rs Show resolved Hide resolved
lazy-pages/src/tests.rs Outdated Show resolved Hide resolved
lazy-pages/src/utils.rs Outdated Show resolved Hide resolved
pallets/gear/src/manager/journal.rs Outdated Show resolved Hide resolved
@tltsutltsu tltsutltsu added A0-pleasereview PR is ready to be reviewed by the team and removed A0-pleasereview PR is ready to be reviewed by the team labels Jun 23, 2023
@tltsutltsu tltsutltsu added A0-pleasereview PR is ready to be reviewed by the team and removed A0-pleasereview PR is ready to be reviewed by the team labels Jun 23, 2023
@tltsutltsu
Copy link
Contributor Author

I have tested on Linux and macOS by running and syncing the node from block 0 to the current state on the testnet, and everything works fine

@tltsutltsu tltsutltsu added A0-pleasereview PR is ready to be reviewed by the team and removed A0-pleasereview PR is ready to be reviewed by the team labels Jun 26, 2023
@tltsutltsu tltsutltsu marked this pull request as ready for review June 26, 2023 15:33
@tltsutltsu tltsutltsu force-pushed the tltsutltsu/merge-lazy-pages-realisations branch from cb6ef9f to 80cc270 Compare June 26, 2023 16:50
@tltsutltsu tltsutltsu added A0-pleasereview PR is ready to be reviewed by the team and removed A0-pleasereview PR is ready to be reviewed by the team labels Jun 26, 2023
@tltsutltsu tltsutltsu added A0-pleasereview PR is ready to be reviewed by the team and removed A0-pleasereview PR is ready to be reviewed by the team labels Jun 26, 2023
grishasobol
grishasobol approved these changes Jun 27, 2023
View reviewed changes
lazy-pages/src/utils.rs Outdated Show resolved Hide resolved
@grishasobol grishasobol requested a review from ark0f June 27, 2023 14:54
ark0f
ark0f approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@ark0f ark0f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

core-backend/common/src/tests.rs Outdated Show resolved Hide resolved
core/src/pages.rs Outdated Show resolved Hide resolved
@ark0f ark0f added the D1-core Gear Core label Jun 29, 2023
@tltsutltsu tltsutltsu merged commit 80e4837 into master Jun 30, 2023
10 checks passed
@tltsutltsu tltsutltsu deleted the tltsutltsu/merge-lazy-pages-realisations branch June 30, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grishasobol grishasobol grishasobol approved these changes

@ark0f ark0f ark0f approved these changes

Assignees

@tltsutltsu tltsutltsu

Labels
A0-pleasereview PR is ready to be reviewed by the team D1-core Gear Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

join memory pages realisations and pages in gear-core
3 participants
@tltsutltsu @grishasobol @ark0f