Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wasm-builder): remove limit on generated files #2900

Merged
merged 1 commit into from
Jul 4, 2023
Merged

fix(wasm-builder): remove limit on generated files #2900

merged 1 commit into from
Jul 4, 2023

Conversation

shamilsan
Copy link
Contributor

  • Removed a limit to files generated by gear-wasm-builder as a 4kb limit for wasm_binary.rs is too restrictive.

@gear-tech/dev

Release Notes

  • Removed a 4kb limit for files generated by gear-wasm-builder
  • This limit caused a failure when building large Gear programs due to big wasm_binary.rs auto-generated file. Now there are no limits to making great dApps.

@shamilsan shamilsan added A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes D5-tooling Helper tools and utilities labels Jul 4, 2023
@shamilsan shamilsan merged commit 946ac47 into master Jul 4, 2023
19 checks passed
@shamilsan shamilsan deleted the sy-wasm-builder-remove-limit branch July 4, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grishasobol grishasobol grishasobol approved these changes

@ukint-vs ukint-vs ukint-vs approved these changes

@ark0f ark0f Awaiting requested review from ark0f

@gshep gshep Awaiting requested review from gshep

@clearloop clearloop Awaiting requested review from clearloop

@techraed techraed Awaiting requested review from techraed

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes D5-tooling Helper tools and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shamilsan @grishasobol @ukint-vs