-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(wasm-builder): invert path remapping logic #2902
Conversation
ee98c3c
to
dbbd1fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply fixes for @DennisInSky comments
@breathx #2915 will add a panic handler feature to gstd. It makes sense to enable path remapping only when the panic handler is enabled. If the user uses dependency (such as dapps-gear-lib) that references gstd, the user should disable the panic handler. Otherwise, such dependency will define the panic handler twice, and we will consider it semantically incorrect (also it leads to compile error). Does it make sense to check transitive dependencies for the |
Panic handler may not still contain paths to remap, isn't it? |
dbbd1fd
to
e797df0
Compare
Cargo.toml
before remapping pathe797df0
to
52c9e5a
Compare
344fb1d
to
929cf12
Compare
The ecosystem team can use the "production" profile to remove the username from the wasm binary.