fix(rpc-fns): Fix bug with calculate_gas returning block gas limit
#2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DennisInSky
reviewed
Jul 13, 2023
DennisInSky
approved these changes
Jul 13, 2023
DennisInSky
reviewed
Jul 13, 2023
ark0f
approved these changes
Jul 13, 2023
DennisInSky
approved these changes
Jul 13, 2023
DennisInSky
approved these changes
Jul 13, 2023
shamilsan
reviewed
Jul 13, 2023
ark0f
approved these changes
Jul 13, 2023
breathx
added
A2-mergeoncegreen
breathx
added a commit
that referenced
this pull request
Jul 14, 2023
ukint-vs
pushed a commit
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While calculating gas there is getter for current gas limit of the main node, that will be none if some error occurs in gas tree (e.g. node not found). Same should be for query of its balance (even in other functionality).
That affected calculating that way: we check balance of already consumed node that has 0 balance, so calculator means that execution burned all gas from the node, which initially equals block gas limit.