-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring(wasm-gen): Introduce general generator and memory generator. #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techraed
added
A1-inprogress
Issue is in progress or PR draft is not ready to be reviewed
D5-tooling
Helper tools and utilities
labels
Jul 26, 2023
techraed
added
A0-pleasereview
PR is ready to be reviewed by the team
and removed
A1-inprogress
Issue is in progress or PR draft is not ready to be reviewed
labels
Jul 26, 2023
techraed
force-pushed
the
st-refactor-wasm-gen-2
branch
from
August 2, 2023 15:10
dd0416d
to
4425107
Compare
techraed
requested review from
gshep,
grishasobol,
DennisInSky and
StackOverflowExcept1on
August 2, 2023 15:14
gshep
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
grishasobol
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR from set of wasm-gen refactoring PRs.
This one mostly shows and idea of generators state-machine and separates each significant step of gear wasm generation to a separate step.
@gear-tech/dev