Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring(wasm-gen): Introduce general generator and memory generator. #2982

Merged
merged 10 commits into from
Aug 2, 2023

Conversation

techraed
Copy link
Member

This is the second PR from set of wasm-gen refactoring PRs.

This one mostly shows and idea of generators state-machine and separates each significant step of gear wasm generation to a separate step.

@gear-tech/dev

@techraed techraed added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed D5-tooling Helper tools and utilities labels Jul 26, 2023
@techraed techraed self-assigned this Jul 26, 2023
@techraed techraed added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Jul 26, 2023
Base automatically changed from st-refactor-wasm-gen-1 to master August 2, 2023 14:55
Copy link
Member

@gshep gshep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

utils/wasm-gen/src/wasm.rs Show resolved Hide resolved
utils/wasm-gen/src/generator.rs Outdated Show resolved Hide resolved
utils/wasm-gen/src/generator.rs Outdated Show resolved Hide resolved
utils/wasm-gen/src/generator/memory.rs Show resolved Hide resolved
@techraed techraed merged commit 5967121 into master Aug 2, 2023
11 checks passed
@techraed techraed deleted the st-refactor-wasm-gen-2 branch August 2, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team D5-tooling Helper tools and utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants