-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gstd): propagate stack allocations #3007
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StackOverflowExcept1on
added
the
A0-pleasereview
PR is ready to be reviewed by the team
label
Jul 31, 2023
StackOverflowExcept1on
force-pushed
the
av/stack-allocation-2
branch
from
July 31, 2023 16:19
37bc3c1
to
6193f49
Compare
breathx
reviewed
Aug 2, 2023
breathx
approved these changes
Aug 6, 2023
ukint-vs
approved these changes
Aug 14, 2023
I think we can make the write method infallible because:
Performance impact:
|
This reverts commit e88e369.
ukint-vs
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2880
Changes:
msg::send*(...)
,msg::reply*(...)
,{prog, ProgramGenerator}::create_program<E>*(...)
might use stack allocation ifpayload.encoded_size()
is less than 64 KiBload_on_stack
andreply_on_stack
fromgstd
gstd::prelude
re-exportsMaxEncodedLen
#[derive(MaxEncodedLen)]
, then due to the specialization, encoding on stack is faster (no need to calculate the size)