Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manifest): complete the manifest of all published libraries #3041

Merged
merged 8 commits into from
Aug 15, 2023

Conversation

clearloop
Copy link
Member

@clearloop clearloop commented Aug 8, 2023

Resolves #2940
part of #2923
split from #2924

complete the manifest of for all published libraries

status package categories keywords
common wasm gear, wasm
common-codegen wasm gear, wasm, codegen
core-backend-codegen wasm gear, wasm, codegen
core-backend-common wasm gear, wasm
core-backend-wasmi wasmi gear, wasm, wasm-executor
core-errors gear
core-processor wasm gear, wasm
core wasm gear, wasm
gcli command-line-interface, command-line-utilities, wasm gear, cli, wasm
gclient api-bindings, wasm gear, sdk, api
gmeta wasm gear, wasm
gmeta-codegen wasm gear, codegen
gsdk wasm, api-bindings gear, sdk, api
gsdk-codegen api-bindings gear, sdk, codegen
gsys wasm, api-bindings gear, wasm
wasm-instrument wasm gear, wasm

@gear-tech/dev

@clearloop clearloop changed the title feat(manifest): complete the manifest of for all published libraries feat(manifest): complete the manifest of all published libraries Aug 8, 2023
@StackOverflowExcept1on
Copy link
Member

StackOverflowExcept1on commented Aug 8, 2023

we can also fill the categories field in Cargo.toml
https://doc.rust-lang.org/cargo/reference/manifest.html#the-categories-field

For example, use wasm for executors and command-line-utilities for gcli.

@clearloop clearloop marked this pull request as ready for review August 10, 2023 06:20
@clearloop clearloop added the A0-pleasereview PR is ready to be reviewed by the team label Aug 10, 2023
Copy link
Contributor

@shamilsan shamilsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the versions. It may be simpler to maintain when the version is the only one (in the workspace).

Cargo.toml Outdated Show resolved Hide resolved
utils/wasm-instrument/Cargo.toml Outdated Show resolved Hide resolved
gsdk/codegen/Cargo.toml Outdated Show resolved Hide resolved
gsdk/Cargo.toml Outdated Show resolved Hide resolved
gclient/Cargo.toml Outdated Show resolved Hide resolved
core-errors/Cargo.toml Outdated Show resolved Hide resolved
common/codegen/Cargo.toml Outdated Show resolved Hide resolved
gsys/Cargo.toml Outdated Show resolved Hide resolved
gmeta/codegen/Cargo.toml Outdated Show resolved Hide resolved
gmeta/Cargo.toml Outdated Show resolved Hide resolved
@clearloop
Copy link
Member Author

clearloop commented Aug 10, 2023

I am not sure about the versions. It may be simpler to maintain when the version is the only one (in the workspace).

agree, I was considering that I may publish some dirty versions in the following PRs, so leaving some spaces for those operations, but it's actually okay to sync them since I can publish some alpha version at that time

core-processor/Cargo.toml Outdated Show resolved Hide resolved
@clearloop clearloop merged commit b527d8b into master Aug 15, 2023
7 checks passed
@clearloop clearloop deleted the cl/issue-2940 branch August 15, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add description for each package
4 participants