Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gstd): log the panic message for the debugging convenience #3045

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

fluiderson
Copy link
Collaborator

#2200 broke the the printing of panic messages in gtest tests due to removing a log function to do so. This PR adds it back for debug builds just before calling gr_panic.

@fluiderson fluiderson added A0-pleasereview PR is ready to be reviewed by the team D3-gstd Gear Standard Library C0-bug Something isn't working labels Aug 9, 2023
@fluiderson fluiderson self-assigned this Aug 9, 2023
Copy link
Contributor

@shamilsan shamilsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 🔥

@fluiderson fluiderson merged commit e3705f4 into master Aug 9, 2023
7 checks passed
@fluiderson fluiderson deleted the as-log-panic branch August 9, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team C0-bug Something isn't working D3-gstd Gear Standard Library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants