Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(sandbox): Extract dispatch_common function in wasmer backend #3068

Merged
merged 1 commit into from
Aug 16, 2023
Merged

refactor(sandbox): Extract dispatch_common function in wasmer backend #3068

merged 1 commit into from
Aug 16, 2023

Conversation

gshep
Copy link
Member

@gshep gshep commented Aug 15, 2023

Resolves #3067

@gear-tech/dev

@gshep gshep added A0-pleasereview PR is ready to be reviewed by the team D2-node Gear Node C2-refactoring Refactoring proposal labels Aug 15, 2023
@gshep gshep requested review from ark0f and breathx August 15, 2023 09:40
@gshep gshep self-assigned this Aug 15, 2023
@gshep gshep changed the title refactor(sandob): Extract dispatch_common function in wasmer backend refactor(sandbox): Extract dispatch_common function in wasmer backend Aug 15, 2023
shamilsan
shamilsan approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@shamilsan shamilsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 💯

sandbox/host/src/sandbox/wasmer_backend.rs Show resolved Hide resolved
@gshep gshep merged commit 27cab78 into master Aug 16, 2023
7 checks passed
@gshep gshep deleted the gshep/issue-3067 branch August 16, 2023 06:06
clearloop pushed a commit that referenced this pull request Aug 18, 2023
@gshep @clearloop
refactor(sandbox): Extract dispatch_common function in wasmer backend (…
26b3423 
…#3068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamilsan shamilsan shamilsan approved these changes

@ukint-vs ukint-vs ukint-vs approved these changes

@ark0f ark0f Awaiting requested review from ark0f

@breathx breathx Awaiting requested review from breathx

Assignees

@gshep gshep

Labels
A0-pleasereview PR is ready to be reviewed by the team C2-refactoring Refactoring proposal D2-node Gear Node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify dispatch_function{, _v2} in wasmer_backend
3 participants
@gshep @shamilsan @ukint-vs