feat(cli): Add node CLI arg to set max block gas value #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekovalev
added
A0-pleasereview
ekovalev
force-pushed
the
ek-max-gas-node-cli-arg
branch
from
7b3db1c
to
818d537
Compare
ekovalev
changed the title
ekovalev
force-pushed
the
ek-max-gas-node-cli-arg
branch
from
818d537
to
7d0734a
Compare
ukint-vs
approved these changes
Aug 19, 2023
shamilsan
reviewed
Aug 19, 2023
NikVolf
reviewed
Aug 19, 2023
NikVolf
approved these changes
Aug 19, 2023
breathx
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables
--max-gascommand line argument to set a hard limit for the amount of gas a validator can spend in one block for the message queue processing.Useful to reduce pressure on validators in case of the network congestion (DDoS attack or whatnot) to keep producing blocks at constant rate and not disable the queue processing completely.
Implementation wise, this value, if set, is propagated to the block authorship module in the client and then passed as a parameter to the
Gear::run()extrinsic through aruntime-api, which will from now on take anOption<u64>as an argument.