Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove to need to set up a workspace_status_command #1

Closed
gebn opened this issue Feb 1, 2019 · 1 comment
Closed

Remove to need to set up a workspace_status_command #1

gebn opened this issue Feb 1, 2019 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@gebn
Copy link
Owner

gebn commented Feb 1, 2019

Ideally, people wanting to use the library would only have to write the go_repository rule - the library would take care of adding necessary keys to the workspace status. Volatile build variables are provided for free by Bazel, however the STABLE_GIT_ ones must be provided by us - we effectively need a way to append to bazel-out/stable-status.txt within Starlark.
@gebn gebn added the help wanted Extra attention is needed label Feb 1, 2019
@gebn
Copy link
Owner Author

gebn commented Oct 25, 2020

This may be possible with custom rules, but even if it is, the current way is the right way.

@gebn gebn closed this as completed Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gebn