Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling #8

Closed
gebn opened this issue Jun 8, 2018 · 2 comments
Closed

Improve error handling #8

gebn opened this issue Jun 8, 2018 · 2 comments
Labels
bug

Comments

@gebn
Copy link
Owner

gebn commented Jun 8, 2018

Exiting with the number of failed messages is inadequate - Lambda will believe the function succeeded, and they will not be retried.
@gebn gebn added the bug label Jun 8, 2018
@gebn
Copy link
Owner Author

gebn commented Jun 8, 2018

It would be far easier to reason about if the function only accepted a single message to send. Want to send two messages? Send two SNS notifications. Clear success/fail and retry.

@gebn
Copy link
Owner Author

gebn commented Dec 15, 2018

There will only ever be a single message.

@gebn gebn closed this as completed in 640d68f Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gebn