Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix draw control editing bug #2046

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Fix draw control editing bug #2046

merged 5 commits into from
Jul 15, 2024

Conversation

giswqs
Copy link
Member

@giswqs giswqs commented Jun 15, 2024

This PR fixes the draw control bug reproted in #1899. In addtion, I improved the redraw_layer() function by utilizing substitute layer rather than removing and adding layer. This avoids the layer flickering.

Colab: https://colab.research.google.com/drive/1E9Uf4WJV060BDnH1yiwA0k5eajtLbmGj?usp=sharing

Note: The recent GDAL version fails on Windows GitHub Actions. It is irrelevant to this PR. I commented it out temporarily.

Peek 2024-06-15 20-42

Copy link

github-actions bot commented Jun 15, 2024

@github-actions github-actions bot temporarily deployed to pull request June 15, 2024 22:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 15, 2024 22:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 16, 2024 00:43 Inactive
@giswqs giswqs linked an issue Jun 16, 2024 that may be closed by this pull request
geemap/core.py Outdated Show resolved Hide resolved
geemap/core.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 24, 2024 21:13 Inactive
@giswqs
Copy link
Member Author

giswqs commented Jul 8, 2024

@naschmitz @sufyanAbbasi Are you Ok with merging the PR? It would be great to fix this long-standing draw control bug and include it in the next release.

@giswqs giswqs merged commit a0a79c4 into master Jul 15, 2024
15 checks passed
@giswqs giswqs deleted the draw branch July 15, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draw_control.features is inaccurate after editing a drawn object
2 participants