Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move all test from data_regression to num_regression #180

Closed
12rambau opened this issue Jan 29, 2024 · 0 comments · Fixed by #205
Closed

move all test from data_regression to num_regression #180

12rambau opened this issue Jan 29, 2024 · 0 comments · Fixed by #205
Assignees
Labels
kind: maintenance Improving maintainability and reducing technical debt tag: CI Pull requests that update GitHub Actions code

Comments

@12rambau
Copy link
Member

Earth engine is not always exporting results with the same rounded value (we are talking about the 10th decimal). This makes most of the tests very fragile.

I realized that pytest-regression is equipped with a num_regression fixture that is dedicted to compare numerical value with a default tolerance set to e-8 which would make the test more stable.

It can safely be used on every image regressions as we compute a reducer to get the datas.

nice side effect: it will reduce the size of the repository as csv are lighter than yml files.

@12rambau 12rambau added kind: maintenance Improving maintainability and reducing technical debt tag: CI Pull requests that update GitHub Actions code labels Jan 29, 2024
@12rambau 12rambau self-assigned this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: maintenance Improving maintainability and reducing technical debt tag: CI Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant