Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: undefined reference to `strncmp_P' when using ESP8266 #2

Open
PotatoX opened this issue Nov 25, 2017 · 4 comments
Open

Error: undefined reference to `strncmp_P' when using ESP8266 #2

PotatoX opened this issue Nov 25, 2017 · 4 comments
Assignees

Comments

@PotatoX
Copy link

PotatoX commented Nov 25, 2017

The Arduino IDE generates a compile error when building for ESP8266. I will generate a pull request to fix. The issue is around the strncmp call when using the ESP8266 core. I am currently using 2.4.0-RC2. I was able to confirm the error persists with 2.4.0-RC1 as well.

@PotatoX
Copy link
Author

PotatoX commented Nov 25, 2017

Pull request #3 created to fix issue.

@PotatoX
Copy link
Author

PotatoX commented Nov 26, 2017

Turns out the arduino linker doesnt like the .c naming. Change shell.c to shell.cpp. Fixed.

@geekfactory
Copy link
Owner

Hello.

I compiled the code for ESP8266 a few months ago and it worked. I´ll check and find out if a better solution is available, since this code is also meant for ohter platforms that only have C compilers available.

Thank you.

@geekfactory
Copy link
Owner

I confirmed the issue with 2.4.0-RC2 and 2.4.0-RC2, the issue was not present back when i tested with esp8266 because the command strings where stored on RAM at that time. At this time 2.4.0 is out and this issue no longer persists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants