Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The subtitles are blocked in full screen. #56

Closed
msterzhang opened this issue Nov 10, 2020 · 8 comments
Closed

The subtitles are blocked in full screen. #56

msterzhang opened this issue Nov 10, 2020 · 8 comments

Comments

@msterzhang
Copy link

image
image

@ahujaraghav
Copy link
Collaborator

@msterzhang can you please describe the issue

@msterzhang
Copy link
Author

@msterzhang can you please describe the issue

Thank you for your reply,The mobile phone screen ratio adapted by the application is 16:9, and the full-screen mobile phone screen ratio is greater than or equal to 18:9. After the video is full, it will be stretched, causing the subtitles to be blocked.

@ahujaraghav
Copy link
Collaborator

@msterzhang did you try changing the videoFit property in fullscreen mode like this

FlickVideoPlayer(
          flickManager: flickManager,
          flickVideoWithControls: FlickVideoWithControls(
            controls: FlickPortraitControls(),
          ),
          flickVideoWithControlsFullscreen: FlickVideoWithControls(
            controls: FlickLandscapeControls(),
            videoFit: BoxFit.contain,
          ),
        )

@msterzhang
Copy link
Author

I haven't tried it like this. I will test it when I come home from a business trip, thank you!

@msterzhang
Copy link
Author

@msterzhang did you try changing the videoFit property in fullscreen mode like this

FlickVideoPlayer(
          flickManager: flickManager,
          flickVideoWithControls: FlickVideoWithControls(
            controls: FlickPortraitControls(),
          ),
          flickVideoWithControlsFullscreen: FlickVideoWithControls(
            controls: FlickLandscapeControls(),
            videoFit: BoxFit.contain,
          ),
        )

Thank you very much for your work, this is effective!

@vipinnegi90
Copy link

@msterzhang How did you manage to get subtitles? Is it embedded on video or different file?

@msterzhang
Copy link
Author

@msterzhang How did you manage to get subtitles? Is it embedded on video or different file?

embedded on video

@vipinnegi90
Copy link

Okay thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants