Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excon basics (Unix socket) test - no implicit conversion from nil to integer (TypeError) #387

Closed
pravi opened this issue May 20, 2014 · 4 comments

Comments

@pravi
Copy link

pravi commented May 20, 2014

Excon basics (Unix socket)
no implicit conversion from nil to integer (TypeError)
/tmp/buildd/ruby-excon-0.33.0/tests/test_helper.rb:286:in kill' /tmp/buildd/ruby-excon-0.33.0/tests/test_helper.rb:286:inensure in with_unicorn'
/tmp/buildd/ruby-excon-0.33.0/tests/test_helper.rb:291:in with_unicorn' /tmp/buildd/ruby-excon-0.33.0/tests/basic_tests.rb:105:inblock in <top (required)>'
/usr/lib/ruby/vendor_ruby/shindo.rb:79:in instance_eval' /usr/lib/ruby/vendor_ruby/shindo.rb:79:intests'
/usr/lib/ruby/vendor_ruby/shindo.rb:38:in initialize' /usr/lib/ruby/vendor_ruby/shindo.rb:13:innew'
/usr/lib/ruby/vendor_ruby/shindo.rb:13:in tests' /tmp/buildd/ruby-excon-0.33.0/tests/basic_tests.rb:101:in<top (required)>'
/usr/lib/ruby/vendor_ruby/shindo/bin.rb:61:in load' /usr/lib/ruby/vendor_ruby/shindo/bin.rb:61:inblock (2 levels) in run_in_thread'
/usr/lib/ruby/vendor_ruby/shindo/bin.rb:58:in each' /usr/lib/ruby/vendor_ruby/shindo/bin.rb:58:inblock in run_in_thread'

same error with excon 0.32.1 as well.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=746079

@pravi
Copy link
Author

pravi commented May 20, 2014

This was fixed after installing unicorn, please add it as a build dependency in gemspec.

@geemus
Copy link
Contributor

geemus commented May 22, 2014

I believe the difficulty is that we only want to conditionally require unicorn for testing (as it does not play nice with jruby). Gemfile allows for this condition, but gemspecs do not. Does that make sense? Is there any way to work around this on your end? For our CI we expect bundle install && bundle exec rake or similar, which seems to work well across ruby implementations.

@pravi
Copy link
Author

pravi commented May 22, 2014

Okay. We don't have jruby yet, so we'll just add unicorn to our build dependencies.

@pravi pravi closed this as completed May 22, 2014
@geemus
Copy link
Contributor

geemus commented May 22, 2014

Thanks, sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants