Adds Project Tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fork Updates
Updates to latest
This commit adds a .DS_Store rule. MacOS folder metdata need not be committed. Signed-off-by: Lui de la Parra <Lui@mutesymphony.com>
This commit adds dependencies to enable automated testing and code coverage reporting to this project. This commit adds development dependencies of nyc, mocha, chai, and mocha-lcov-reporter. This commit fixes the npm test script to use the added dependencies and adds an additional script, the coverage script, to enable coverage reporting of this project. Signed-off-by: Lui de la Parra <Lui@mutesymphony.com>
This commit migrates the test runner from Mocha to Jest. Mocha’s compiler flag is depricated. This makes transpilation of code via babel untenable. I also ran into issues using jsdom to construct the dom during tests. Using Jest as a test runner reduces the level of effort for creating tests. Signed-off-by: Lui de la Parra <Lui@mutesymphony.com>
This commit adds dependencies designed to enable a standard code format. Signed-off-by: Lui de la Parra <lui@mutesymphony.com>
This commit adds ESLint configuration to the project. Thsi commit adds eslint via rollup configuration and a eslintrc.js file Signed-off-by: Lui de la Parra <lui@mutesymphony.com>
This commit revises the testing strategy to use jest instead of mocha. Signed-off-by: Lui de la Parra <lui@mutesymphony.com>
This commit revises project styling to enforce using a tab width of 2. This was done to conform with the code styling of modular filemaker. Additionally this commit removes the no console error until the main file console logging functionality is revised. Signed-off-by: Lui de la Parra <lui@mutesymphony.com>
This commit updates the coverage reporter to use html instead of clover. Signed-off-by: Lui de la Parra <lui@mutesymphony.com>
This commit adds additional tests. This commit raises code coverage above 80%. This is our goal for an initial pull request. Signed-off-by: Lui de la Parra <lui@mutesymphony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a project testing framework and tests. This pull request makes no changes to the project source code base. This pull request should close issue #4
This pull request also adds a standard project format by adding ESLint and prettier.