Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't get images to align #49

Closed
gcb opened this issue Jun 26, 2017 · 6 comments
Closed

can't get images to align #49

gcb opened this issue Jun 26, 2017 · 6 comments

Comments

@gcb
Copy link

gcb commented Jun 26, 2017

This is how oneup looks for me on my github enterprise account. Pretty much everything is default (just pressed return for offset, etc)

screen shot 2017-06-26 at 10 58 03

Any ideas what i am doing wrong? I am using latest commit 9feaf24

Is this because enterprise might use a different timezone?

I tried to change the oneup template to debug what is appearing where, and used:

  [4,4,4,4,4,4,4,4,4],
  [4,0,0,0,0,0,0,0,4],
  [4,0,0,0,0,0,0,0,4],
  [4,0,0,3,3,0,0,0,4],
  [4,0,0,3,3,0,0,0,4],
  [4,0,0,0,0,0,0,0,4],
  [4,4,4,4,4,4,4,4,4],

And this is what i get:
screen shot 2017-06-26 at 11 23 42

Thanks!

@gelstudios
Copy link
Owner

Strange, in the first example, it looks like only the right half of oneup was drawn.

In the second image, it looks like you're missing the three columns left of the 3,3 blocks.

Based on the shapes being correct, I do not think this a bug. But might be an optimization GH does with commits close to the end of the calendar.

I would try using an offset of 4 to see if that helps.

Depending on what version of enterprise you are using, there should be a button in your profile to rebuild the contributions data.

@gcb
Copy link
Author

gcb commented Jun 27, 2017

tried offset of 15, same thing happened, but moved to the right.

@gcb
Copy link
Author

gcb commented Jun 27, 2017

Tried here too to rule out anything strange from enterprise github.

It simply cuts all commits from a few months. On the repo i can clearly see commits on, say, 2016-09-29. Dozens of them. But on the profile page, that day shows up empty. Even if i click that day it will say "no commits". So i guess it is github that doesn't want to play nice anymore with this.

@gelstudios
Copy link
Owner

gelstudios commented Jun 28, 2017

There was a change in #42 that removed "add a new line + commit" behavior and added an "allow empty" argument to git, do you want to try a revision before that changed? or you can edit the lines starting around ~286 ish ?

@mytopdog
Copy link

mytopdog commented Jan 4, 2018

Close issues smh

@gcb
Copy link
Author

gcb commented Jan 25, 2018

did try reverting the #42 changes. still no luck. even with new repos. will try on open github and see if things change or not later. but on GH enterprise it does not align no matter what.

writting this off as some performance tweak on my GHE instance that messes up with the image by cutting some process short.

@gcb gcb closed this as completed Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants