Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Go version 1.19 #49

Merged
merged 2 commits into from
Aug 22, 2022
Merged

feat: Go version 1.19 #49

merged 2 commits into from
Aug 22, 2022

Conversation

yag13s
Copy link
Contributor

@yag13s yag13s commented Aug 18, 2022 •
edited
Loading

Pull Request Template

Description

Update Go version to 1.19 and slight modification to lint settings.

Fixes #13

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@yag13s yag13s added the enhancement New feature or request label Aug 18, 2022
@yag13s yag13s added this to the v1.1.1 milestone Aug 18, 2022
@yag13s yag13s self-assigned this Aug 18, 2022
@yag13s yag13s added this to In progress in Development via automation Aug 18, 2022
@yag13s
Copy link
Contributor Author

yag13s commented Aug 18, 2022

Dont see a problem since there is no functionality that depends on 1.19.

@yag13s yag13s requested a review from yoshi966 August 18, 2022 08:59
@yag13s yag13s merged commit fd83593 into gemcook:main Aug 22, 2022
Development automation moved this from In progress to Done Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ss49919201 ss49919201 Awaiting requested review from ss49919201

@A-ichi11 A-ichi11 Awaiting requested review from A-ichi11

@yoshi966 yoshi966 Awaiting requested review from yoshi966

Assignees

@yag13s yag13s

Labels
enhancement New feature or request
Projects
Development
Done
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

Dependency Dashboard
1 participant
@yag13s