Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q has no method 'getUnhandledReasons' #10

Merged
merged 1 commit into from
Mar 22, 2016
Merged

Q has no method 'getUnhandledReasons' #10

merged 1 commit into from
Mar 22, 2016

Conversation

tarmolov
Copy link
Contributor

When I specified debug option in the config file, I'll got the following error:

TypeError: Object function Q(value) {
   // If the object is already a Promise, return it directly.  This enables
   // the resolve function to both be used to created references from objects,
   // but to tolerably coerce non-promises to promises.
   if (Q_isPromise(value)) {
       return value;
   } else if (isThenable(value)) {
       if (!thenables.has(value)) {
           thenables.set(value, new Promise(new Thenable(value)));
       }
       return thenables.get(value);
   } else {
       return new Promise(new Fulfilled(value));
   }
} has no method 'getUnhandledReasons'

hermione uses q library v2 which doesn't have getUnhandledReasons method anymore.
It seems that q-debug-mode is useless now and can be pruned.

/cc @j0tunn

@j0tunn
Copy link
Contributor

j0tunn commented Mar 22, 2016

/cc @SwinX

@SwinX
Copy link
Contributor

SwinX commented Mar 22, 2016

Seems q is not being used anywhere except qDebugMode in lib/hermione.js. Need to remove in order to fix lint issues.

@SwinX
Copy link
Contributor

SwinX commented Mar 22, 2016

🆗 for PR.

@tarmolov
Copy link
Contributor Author

:shipit:

@SwinX
Copy link
Contributor

SwinX commented Mar 22, 2016

Thank you!

SwinX added a commit that referenced this pull request Mar 22, 2016
Q has no method 'getUnhandledReasons'
@SwinX SwinX merged commit d290a47 into gemini-testing:master Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants