fix: do not ignore assertView errors in broken session rejection #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
approved these changes
Oct 17, 2023
|
|
||
| it("should not mark session as broken twice", async () => { | ||
| session.commandList = ["foo"]; | ||
| session.foo = () => "foo"; |
There was a problem hiding this comment.
А зачем тебе эти 2 строки (такое ощущение, что можно выгасить)?
There was a problem hiding this comment.
при стабе комманд мы проходимся именно по списку команд из commandList. И стабаем только те команды, которые являются функциями
| // we need to check session twice: | ||
| // 1. before afterEach hook to prevent work with broken sessions | ||
| // 2. after collecting all assertView errors (including afterEach section) | ||
| if (isSessionBroken(error, this._config)) { |
There was a problem hiding this comment.
Может тут добавить условие - browser.state.isBroken (оно публичное)?
| @@ -491,7 +492,7 @@ describe("worker/runner/test-runner", () => { | |||
|
|
|||
| await run_({ runner }).catch(() => {}); | |||
|
|
|||
| assert.calledOnce(browser.markAsBroken); | |||
| assert.calledTwice(browser.markAsBroken); | |||
There was a problem hiding this comment.
Немного странно теперь тут проверки выглядят. Я бы все таки один раз вызывал (выше писал про это)
sipayRT
force-pushed
the
sp.HERMIONE-1187.patternsOnReject
branch
from
75708f6
to
7059cef
Compare
sipayRT
force-pushed
the
sp.HERMIONE-1187.patternsOnReject
branch
from
7059cef
to
b65fe38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.