feat: add ability to use devtools procotol through cli option #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
force-pushed
the
HERMIONE-1333.devtools_cli_option
branch
from
ca4199f
to
b085065
Compare
DudaGod
commented
Jan 16, 2024
| @@ -67,6 +67,7 @@ exports.run = () => { | |||
| ) | |||
| .option("--repl-before-test [type]", "open repl interface before test run", Boolean, false) | |||
| .option("--repl-on-fail [type]", "open repl interface on test fail only", Boolean, false) | |||
| .option("--devtools", "switches the browser to the devtools mode with using CDP protocol") | |||
There was a problem hiding this comment.
Если опция не указана, то devtools: undefined, а если указана то devtools: true
| @@ -99,6 +101,7 @@ exports.run = () => { | |||
| beforeTest: replBeforeTest, | |||
| onFail: replOnFail, | |||
| }, | |||
| devtools: devtools || false, | |||
There was a problem hiding this comment.
Если devtools не указана пользователем, то привожу опцию к false
| reporters = [], | ||
| }: Partial<RunOpts> = {}, | ||
| ): Promise<boolean> { | ||
| validateUnknownBrowsers(browsers, _.keys(this._config.browsers)); | ||
|
|
||
| RuntimeConfig.getInstance().extend({ updateRefs, requireModules, inspectMode, replMode }); | ||
| RuntimeConfig.getInstance().extend({ updateRefs, requireModules, inspectMode, replMode, devtools }); |
There was a problem hiding this comment.
Опцию переданную из cli сохраняю в runtime конфиге, чтобы затем заюзать при создании браузера.
DudaGod
force-pushed
the
HERMIONE-1333.devtools_cli_option
branch
from
b085065
to
7750da9
Compare
sipayRT
approved these changes
Jan 16, 2024
src/browser/new-browser.js
Outdated
| @@ -100,7 +102,7 @@ module.exports = class NewBrowser extends Browser { | |||
| path: gridUri.path(), | |||
| queryParams: this._getQueryParams(gridUri.query()), | |||
| capabilities, | |||
| automationProtocol: config.automationProtocol, | |||
| automationProtocol: devtools ? "devtools" : config.automationProtocol, | |||
There was a problem hiding this comment.
почему ты в тестах используешь константу DEVTOOLS_PROTOCOL, а здесь строкой добавляешь?
There was a problem hiding this comment.
Забыл тут заюзать, поправил.
DudaGod
force-pushed
the
HERMIONE-1333.devtools_cli_option
branch
from
7750da9
to
852f375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done
add ability to use devtools procotol through cli option
--devtoolsin order to make it easier to switch between the two protocols (devtoolsandwebdriver).